Re: [PATCH v3] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem

From: kernel test robot
Date: Wed Jan 05 2022 - 13:52:55 EST


Hi Charan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hnaz-mm/master]

url: https://github.com/0day-ci/linux/commits/Charan-Teja-Reddy/mm-shmem-implement-POSIX_FADV_-WILL-DONT-NEED-for-shmem/20220105-230604
base: https://github.com/hnaz/linux-mm master
config: nds32-allnoconfig (https://download.01.org/0day-ci/archive/20220106/202201060232.K03lKwTH-lkp@xxxxxxxxx/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6bdb2636187d2f6cb78d6cdc05f2b7e0b79c750a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Charan-Teja-Reddy/mm-shmem-implement-POSIX_FADV_-WILL-DONT-NEED-for-shmem/20220105-230604
git checkout 6bdb2636187d2f6cb78d6cdc05f2b7e0b79c750a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> mm/shmem.c:4000:27: error: 'shmem_fadvise' undeclared here (not in a function); did you mean 'shmem_file'?
4000 | .fadvise = shmem_fadvise,
| ^~~~~~~~~~~~~
| shmem_file


vim +4000 mm/shmem.c

3987
3988 static const struct file_operations shmem_file_operations = {
3989 .mmap = shmem_mmap,
3990 .get_unmapped_area = shmem_get_unmapped_area,
3991 #ifdef CONFIG_TMPFS
3992 .llseek = shmem_file_llseek,
3993 .read_iter = shmem_file_read_iter,
3994 .write_iter = generic_file_write_iter,
3995 .fsync = noop_fsync,
3996 .splice_read = generic_file_splice_read,
3997 .splice_write = iter_file_splice_write,
3998 .fallocate = shmem_fallocate,
3999 #endif
> 4000 .fadvise = shmem_fadvise,
4001 };
4002

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx