Re: [PATCH v1 1/3] dt-bindings: mmc: add cap-sdio-async-int flag

From: Rob Herring
Date: Tue Jan 04 2022 - 17:33:15 EST


On Mon, Dec 27, 2021 at 04:36:39PM +0800, Axe Yang wrote:
> Asynchronous interrupt is a mechanism that allow SDIO devices alarm
> interrupt when host stop providing clock to card. Add a DT flag to
> enable this feature if it is supported by SDIO card.

A card property should be in the card node. Is this not discoverable?

>
> Signed-off-by: Axe Yang <axe.yang@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 25ac8e200970..7230421583c6 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -165,6 +165,11 @@ properties:
> description:
> eMMC hardware reset is supported
>
> + cap-sdio-async-int:

Perhaps be consistent with the next property and use 'irq'.

> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + SDIO async interrupt is supported.
> +
> cap-sdio-irq:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.25.1
>
>