Re: [Intel-wired-lan] [PATCH] intel: Simplify DMA setting

[Nguyen, Anthony L]

On Tue, 2022-01-04 at 14:29 +0100, Alexander Lobakin wrote:
> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Date: Tue, 4 Jan 2022 01:15:20 +0100
> 
> > As stated in [1], dma_set_mask() with a 64-bit mask will never fail
> > if
> > dev->dma_mask is non-NULL.
> > So, if it fails, the 32 bits case will also fail for the same
> > reason.
> > 
> > Simplify code and remove some dead code accordingly.
> > 
> > [1]: https://lkml.org/lkml/2021/6/7/398
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > ---
> >  drivers/net/ethernet/intel/e1000e/netdev.c    | 22 ++++++---------
> > ----
> >  drivers/net/ethernet/intel/i40e/i40e_main.c   |  9 +++-----
> >  drivers/net/ethernet/intel/iavf/iavf_main.c   |  9 +++-----
> >  drivers/net/ethernet/intel/ice/ice_main.c     |  2 --
> >  drivers/net/ethernet/intel/ixgb/ixgb_main.c   | 19 +++++----------
> > -
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++++++---------
> > --
> >  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 20 +++++----------
> > --
> >  7 files changed, 31 insertions(+), 70 deletions(-)
> 
> I like it, thanks!
> 
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@xxxxxxxxx>
> 
> Tony might ask to split it into per-driver patches tho, will see.

Hi Christophe,

As mentioned by others, would mind breaking these per-driver?

Thanks,
Tony

> 
> --- 8< ---
> 
> Al