Re: [PATCH v3 3/3] scsi: Set allocation length to 255 for ATA Information VPD page

From: Martin K. Petersen
Date: Tue Jan 04 2022 - 12:58:07 EST



Maciej,

> I have tried it and it's neutral, that is with 1/3 applied the HBA still
> works and with 1/3 removed it still breaks (2/3 and 3/3 obviously don't
> build anymore). Unsurprisingly, as it's the call to `scsi_get_vpd_page'
> rather than `scsi_get_vpd_buf' that causes an issue here.

Oh, you'll also need a follow-on patch that uses the cached ATA
Information VPD page. I'll try to get my full series out today.

> NB you'll need to adjust drivers/scsi/mpt3sas/mpt3sas_scsih.c accordingly
> if we are to move forward with this change, as it's another user of the
> SCSI_VPD_PG_LEN macro.

That'll also use cached information in my series.

--
Martin K. Petersen Oracle Linux Engineering