That connotation lid was closed represent human will not use laptop and system must keep it was sleep and even though the laptop was accidentally awakened.
On 16.12.21 11:59, zhuyinbo wrote:
Hi,
if you only talk about wakeup source you can think that usb-wakeupI am sorry, I am not sure what you wish to say here. Could you rephrase it?
source and acpi-lid wakeup source was different things. but if you
talk about laptop and distinguish lid and other event and you shoud
know the cannotation why system still continue sleep when lid closed
then system by other event wakeup. if you need test usb-wakeup for
laptop and that lid shouldn't be closed.
from the default.
if system can doesn't consider lid open event and ignore the connotation about lid open event I think that system behavior is inappropriate. you don't think my patch was inapproriate that on some system doesn't consider lid open event.you still can has wakeup capability, but it should be keep enabled by
In general any HID device must have wakeup capability to be usable for
selective suspend. You cannot draw conclusions from that.
default. because the hid device should be convenient for human,
Well, no. We are talking about a kernel default. That needs to be so that it
always works on all systems. Convinience is secondary.
bios and kernel was two sets of things and they should has their own indepdent configuration. if bios enable usb wakeup but wakeup is still not work well. Do you think it is appropriate?
if you don't think so and I think HID definition is ridiculous.It does have its weaknesses, in particular with respect to differentiating
between events for wakeups. But we cannot change it.
If you deviate from the default, you deviate. That is reducing the number of
In addition, I had said that laptop usb wakeup was disabled in system
bios by default and if user want enable usb wakeup that was only by
configure bios and doesn't need enable wakeup node if my patch was
applied
changes is worth little. The default must be above everything else safe.
Regards
Oliver