Re: [PATCH] ARM: dts: add DT for lan966x SoC and 2-port board pcb8291

[Tudor.Ambarus]

On 1/4/22 7:20 AM, Kavyasree Kotagiri - I30978 wrote:
>> On 1/3/22 2:48 PM, Kavyasree Kotagiri wrote:
>>> diff --git a/arch/arm/boot/dts/lan966x_pcb8291.dts
>> b/arch/arm/boot/dts/lan966x_pcb8291.dts
>>> new file mode 100644
>>> index 000000000000..cd0454a795e7
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/lan966x_pcb8291.dts
>>> @@ -0,0 +1,55 @@
>>
>>> +&flx3 {
>>> +       atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>>> +       status = "okay";
>>> +
>>> +       usart0: serial@200 {
>>> +               compatible = "atmel,at91sam9260-usart";
>>
>> The flexcom usart mode should be defined in the dtsi file, so that you
>> won't duplicate the definition in each dts that includes the dtsi file.
>>
> defining flexcom mode in dts as flx3 can be used as USART/I2C/SPI on different boards.

Right, you should define the mode in dtsi and enable it in the dts file.

> And it is not the same mode for all boards.
> 
>> Cheers,
>> ta