Re: [PATCH v1 1/1] Revert "net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register"

[Jakub Kicinski]

On Sun,  2 Jan 2022 12:35:57 +0100 Sam Ravnborg wrote:
> This reverts commit b45396afa4177f2b1ddfeff7185da733fade1dc3.
> 
> With the referenced patch applied the following error was seen
> in the kernel log:
> 
> 	fec 2188000.ethernet: broken fixed-link specification
> 	fec: probe of 2188000.ethernet failed with error -22
> 
> The problem is that the implementation makes the
> link-gpios node mandatory - which is not the case.
> 
> fixed_phy_get_gpiod() may return -EPROBE_DEFER so this code needs
> to use IS_ERR() check and the original code was fine.
> 
> Fixes: b45396afa417 ("net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register")
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Miaoqian Lin <linmq006@xxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>

This patch didn't register in patchwork for some reason, I applied 
a very similar patch from Florian instead:

https://patchwork.kernel.org/project/netdevbpf/patch/20220103193453.1214961-1-f.fainelli@xxxxxxxxx/

Not sure why patchwork and lore did not see your posting, sorry :S