Re: [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms

From: Arend van Spriel
Date: Mon Jan 03 2022 - 05:21:15 EST


On 1/3/2022 7:27 AM, Hector Martin wrote:
On 2022/01/02 15:25, Linus Walleij wrote:
On Sun, Dec 26, 2021 at 4:36 PM Hector Martin <marcan@xxxxxxxxx> wrote:

Merry Christmas! This year Santa brings us a 34-patch series to add
proper support for the Broadcom FullMAC chips used on Apple T2 and M1
platforms:

I tried to review as best I could, when I think I know what I'm doing I state
Reviewed-by and when I think it just LooksGoodToMe(TM) I replied
Acked-by. If I missed some patch you can assume Acked-by from me
on these as well.

Thanks for doing this, some really old bugs and code improvements long
overdue is in the series, much appreciated.

Yours,
Linus Walleij


Thanks for the comprehensive review! I'm glad this all makes some sense
and I'm not crazy about the approach :)

I'll wait a bit for any other feedback that might come in and then
submit a v2 with the fixes/changes mentioned so far.

Happy new year to you all. I wanted to start the new year relaxing by reviewing this series, but with the comments already given I prefer to do that with v2 so don't wait for me :-)

Regards,
Arend


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature