Re: [PATCH V3 3/6] dt-bindings: serial: meson: Support S4 SoC uart. Also Drop compatible = amlogic,meson-gx-uart.

[Yu Tu]

On 2021/12/31 6:34, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
>
> Hello,
>
> as Greg already mentioned the $subject line is very long.
>
> On Thu, Dec 30, 2021 at 11:21 AM Yu Tu <yu.tu@xxxxxxxxxxx> wrote:
> > Deprecated, don't use anymore because compatible = amlogic,meson-gx-uart
> > don't differentiate between GXBB and GXL which have different
> > revisions of the UART IP. So it's split into GXBB and GXL.
> actually it's split into GXBB, GXL and G12A
>
> [...]
> > -              - amlogic,meson-gx-uart
> > +              - amlogic,meson-gxbb-uart
> > +              - amlogic,meson-gxl-uart
> > +              - amlogic,meson-g12a-uart
> > +              - amlogic,meson-s4-uart
> In addition to Greg's comment I suggest splitting this into two patches:
> - one where the "amlogic,meson-gx-uart" compatible is marked as
> deprecated (Documentation/devicetree/bindings/power/supply/bq27xxx.yaml
> has an example for deprecated entries) and GXBB, GXL and G12A
> compatible strings are added instead
> - another one where the new S4 compatible string is added
>
> The idea here is to have "one logical change per patch".
> Deprecating and replacing "amlogic,meson-gx-uart" is one logical change.
> Adding a new compatible string is another logical change.
> I am hoping that this will also make it easier to find a shorter
> $subject line (which according to the patch submission guide [0]
> should be 70-75 characters: "the summary must be no more than 70-75
> characters")
I will split the two patches in the next version.One was deprecating and 
replacing "AmLogic, Meson-GX-Uart" and the other added S4 compatible.
> Best regards,
> Martin
>
>
> [0] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format