Re: Missing closing files in linux/scripts/kconfig/confdata.c

[Masahiro Yamada]

On Thu, Dec 30, 2021 at 12:11 PM Ryan Cai <ycaibb@xxxxxxxxx> wrote:
>
> Dear Kernel maintainers,
>
>           1. In linux/scripts/kconfig/confdata.c (conf_write_autoconf_cmd), the file opened at Line 946 may not closed when going to Line 981.
>           Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L964-L981
>
>          2. In linux/scripts/kconfig/confdata.c (__conf_write_autoconf), the file opened at Line1081 may not closed when going to Line 1095,
>            Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L1081-L1095
>
>            I think, the fix is inserting fclose before the returning. Should it be a bug? I can send a patch for these.
>

Yes, they are both bugs.
Thanks for catching them.



-- 
Best Regards
Masahiro Yamada