Re: [PATCH] clk: qcom: gcc-msm8994: Remove NoC clocks

From: Dmitry Baryshkov
Date: Thu Dec 30 2021 - 09:42:44 EST


On Thu, 30 Dec 2021 at 17:29, Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxx> wrote:
>
>
> > You don't have to init array entries with NULL values (if it's not for
> > the documentation purposes). Uninitialized entries will get NULL value
> > anyway.
> >


> Forgot to address this in my previous message, but I think it may be a
>
> good indicator for the next person that decides this would be a good idea
>
> that they should probably stay away from it.. If it's really bad, then sure, I
>
> can remove it..

You can add a comment on top of those assignments telling this, so
that the next person doing the semi-auto cleanup wouldn't delete the
assignments.

--
With best wishes
Dmitry