Re: [PATCH] x86/build: use the proper name CONFIG_FW_LOADER

From: Greg Kroah-Hartman
Date: Thu Dec 30 2021 - 04:29:43 EST


On Wed, Dec 29, 2021 at 08:36:11PM +0100, Borislav Petkov wrote:
> On Wed, Dec 29, 2021 at 12:15:53PM +0100, Lukas Bulwahn wrote:
> > Commit c8dcf655ec81 ("x86/build: Tuck away built-in firmware under
> > FW_LOADER") intends to add the expression regex only when FW_LOADER is
> > built-in, not a module or disabled.
> >
> > The config is called CONFIG_FW_LOADER when it is built-in; and
> > CONFIG_FW_LOADER_MODULE when it is a module.
>
> $ git grep FW_LOADER_MODULE
> include/linux/firmware.h:37:#if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE))
>
> So either I'm not grepping right or that FW_LOADER_MODULE thing belongs
> to the past...
>
> Greg, Luis, what's up?

Looks like a pre-git thing, it is obviously not a valid config option,
so it can be removed. I'll go make a patch for it...

thanks,

greg k-h