Re: [PATCH 4/5] erofs: use meta buffers for xattr operations

[Gao Xiang]

On Wed, Dec 29, 2021 at 12:14:04PM +0800, Gao Xiang wrote:

...

>  
> @@ -659,6 +608,7 @@ ssize_t erofs_listxattr(struct dentry *dentry,
>  	if (ret)
>  		return ret;
>  
> +	it.it.buf = __EROFS_BUF_INITIALIZER;
>  	it.dentry = dentry;
>  	it.buffer = buffer;
>  	it.buffer_size = buffer_size;
> @@ -669,6 +619,7 @@ ssize_t erofs_listxattr(struct dentry *dentry,
>  	ret = inline_listxattr(&it);
>  	if (ret < 0 && ret != -ENOATTR)
>  		return ret;
> +	erofs_put_metabuf(&it.it.buf);
>  	return shared_listxattr(&it);

There is a bug here, I will fix it in the next version.

Thanks,
Gao Xiang

>  }
>  
> -- 
> 2.24.4