Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node

From: Laurent Pinchart
Date: Wed Dec 29 2021 - 12:15:52 EST


Hi Nikita,

On Wed, Dec 29, 2021 at 08:04:18PM +0300, Nikita Yushchenko wrote:
> Hi.
>
> Thank you for looking at this.
>
> >> + port@1 {
> >> + reg = <1>;
> >> + lvds0_out: endpoint {
> >> };
> >
> > Endpoints must have a remote-endpoint property. Let's drop the endpoint
> > here and keep the port only, the endpoint can be declared in board
> > files.
> >
> > If you're fine with this change I can make it when applying the patch.
>
> This empty endpoint is currently defined in dtsi files for other r-car
> gen3 SoCs.
>
> Goal here is to define lvds0_out label that is then used in extension
> board dtsi files to link to the port.
>
> In this patch I just used the same approach as in files laying nearby.
>
> If this approach is not appropriate, then perhaps need to fix it in
> files for all SoCs, to make it possible for extension board dtsi to be
> compatible with all of them.

I'm writing a patch to drop those right now :-) I'll CC you.

--
Regards,

Laurent Pinchart