Re: [RFC v5 net-next 11/13] mfd: ocelot-core: add control for the external mdio interface

From: Lee Jones
Date: Wed Dec 29 2021 - 10:26:30 EST


On Sat, 18 Dec 2021, Colin Foster wrote:

> Utilize the mscc-miim-mdio driver as a child of the ocelot MFD.
>
> Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx>
> ---
> drivers/mfd/ocelot-core.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)

Squash please.

> diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c
> index 52aa7b824d02..c67e433f467c 100644
> --- a/drivers/mfd/ocelot-core.c
> +++ b/drivers/mfd/ocelot-core.c
> @@ -104,7 +104,22 @@ struct regmap *ocelot_mfd_get_regmap_from_resource(struct device *dev,
> }
> EXPORT_SYMBOL(ocelot_mfd_get_regmap_from_resource);
>
> +static const struct resource vsc7512_miim1_resources[] = {
> + {
> + .start = 0x710700c0,
> + .end = 0x710700e3,
> + .name = "gcb_miim1",
> + .flags = IORESOURCE_MEM,
> + },
> +};
> +
> static const struct mfd_cell vsc7512_devs[] = {
> + {
> + .name = "ocelot-miim1",
> + .of_compatible = "mscc,ocelot-miim",
> + .num_resources = ARRAY_SIZE(vsc7512_miim1_resources),
> + .resources = vsc7512_miim1_resources,
> + },
> {
> .name = "ocelot-ext-switch",
> .of_compatible = "mscc,vsc7512-ext-switch",

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog