Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver

From: Lee Jones
Date: Wed Dec 29 2021 - 05:18:46 EST


On Fri, 24 Dec 2021, Quan Nguyen wrote:

> This commit adds driver support for accessing various information
> reported by Ampere's SMpro co-processor such as Boot Progress and
> other miscellaneous data.
>
> Signed-off-by: Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> Change in v6:
> + First introduced in v6 [Quan]
>
> drivers/mfd/smpro-mfd.c | 1 +

Please pull all of these patches out.

There are no build dependencies here.

> drivers/misc/Kconfig | 7 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/smpro-misc.c | 177 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 186 insertions(+)
> create mode 100644 drivers/misc/smpro-misc.c
>
> diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c
> index a7cd64bf9eaa..5611dd30f8f4 100644
> --- a/drivers/mfd/smpro-mfd.c
> +++ b/drivers/mfd/smpro-mfd.c
> @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = {
> static const struct mfd_cell smpro_devs[] = {
> MFD_CELL_NAME("smpro-hwmon"),
> MFD_CELL_NAME("smpro-errmon"),
> + MFD_CELL_NAME("smpro-misc"),

Misc is a Linuxisum which are not allowed in DT.

What does this driver actually do?

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog