Re: [PATCH v2 1/1] hwmon: Add debugfs register access

[Guenter Roeck]

On Tue, Dec 28, 2021 at 06:51:40PM +0200, Cosmin Tanislav wrote:
> 
> 
> On 12/28/21 18:13, Guenter Roeck wrote:
> > On 12/27/21 2:42 PM, Cosmin Tanislav wrote:
> > > From: Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>
> > > 
> > > Similar to IIO, create a device directory inside debugfs
> > > mount point, and create a direct_reg_access file inside
> > > that directory, if debugfs_reg_access callback is defined
> > > inside hwmon_ops.
> > > 
> > 
> > Patch looks good afaics. I don't want to apply it now (ie for 5.17),
> > though, because it is getting close and we don't have a use case.
> > If you have one in mind, I'd suggest to submit it together with
> > this patch, or we'll have to wait until there is a user.
> > 
> > Guenter
> 
> As I mentioned previously I have a local patch on top of the ADT7X10
> refactor that uses this. I tested your modifications to my patchset on
> the ADT7420 part and it seems to work just fine. I can push it on top of
> either this patch or that patchset, your choice.
> 
The adt7x10 patches won't make it into 5.17 either, so all that will
have to wait until 5.18. If I don't get a use case by then I may write
one myself, but that won't happen now because I am about to be away
from my computers for the next two weeks.

Guenter