Re: [RFC 24/32] scsi: Kconfig: add HAS_IOPORT dependencies

[Geert Uytterhoeven]

Hi Niklas,

On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle <schnelle@xxxxxxxxxxxxx> wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
>
> Co-developed-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -793,6 +793,7 @@ config SCSI_INIA100
>  config SCSI_PPA
>         tristate "IOMEGA parallel port (ppa - older drives)"
>         depends on SCSI && PARPORT_PC
> +       depends on HAS_IOPORT

This is not needed, [04/32] already added that dependency to
PARPORT_PC.

>         help
>           This driver supports older versions of IOMEGA's parallel port ZIP
>           drive (a 100 MB removable media device).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds