Re: [PATCH] staging: rtl8192e: rtllib_module: add free for error exit
From: Pavel Skripkin
Date: Mon Dec 27 2021 - 12:43:00 EST
On 12/27/21 11:07, Peiwei Hu wrote:
Original source code of alloc_rtllib returns directly in
error, without freeing variable dev.
Signed-off-by: Peiwei Hu <jlu.hpw@xxxxxxxxxxx>
---
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
index 64d9feee1f39..18d898714c5c 100644
--- a/drivers/staging/rtl8192e/rtllib_module.c
+++ b/drivers/staging/rtl8192e/rtllib_module.c
@@ -125,7 +125,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
ieee->pHTInfo = kzalloc(sizeof(struct rt_hi_throughput), GFP_KERNEL);
if (!ieee->pHTInfo)
- return NULL;
+ goto failed;
HTUpdateDefaultSetting(ieee);
HTInitializeHTInfo(ieee);
This one is already fixed in staging-testing branch. See commit
e730cd57ac2dfe94bca0f14a3be8e1b21de41a9c
With regards,
Pavel Skripkin