Re: [PATCH v4] staging: r8188eu: Use strndup_user instead of kmalloc/copy_from_user

From: Pavel Skripkin
Date: Sat Dec 25 2021 - 13:24:06 EST


On 12/25/21 20:04, Jiapeng Chong wrote:
This code assumes that the user is going to give us a NUL terminated
string which is not necessarily true.

Fix following coccicheck warning:

./drivers/staging/r8188eu/os_dep/ioctl_linux.c:4253:8-15: WARNING
opportunity for memdup_user.

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
---

Subject line and commit message are completely unrelated to the change itself, please fix up.


With regards,
Pavel Skripkin