Re: [PATCH] irqchip/renesas-irqc: Use platform_get_irq_optional() to get the interrupt

From: Andy Shevchenko
Date: Sat Dec 25 2021 - 12:40:36 EST


On Sat, Dec 25, 2021 at 7:28 PM Lad, Prabhakar
<prabhakar.csengg@xxxxxxxxx> wrote:
> On Sat, Dec 25, 2021 at 4:46 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Thu, Dec 16, 2021 at 9:52 AM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:

> > ret = platform_get_irq_optional(...);
> > if (ret < 0 && ret != -ENXIO)
> > return ret;
> > if (ret > 0)
> > ...we got it...
> >
> > It will allow the future API fix of platform_get_irq_optional() to be
> > really optional.
> >
> Later patch [0] (merged into -next) does check for -ENXIO first.
>
> [0] https://lore.kernel.org/lkml/20211216182121.5323-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/t/

The problem is that it doesn't consider 0 as no IRQ.

--
With Best Regards,
Andy Shevchenko