Re: [PATCH v3] soc: ti: smartreflex: Use platform_get_irq_optional() to get the interrupt

[Andy Shevchenko]

On Sat, Dec 25, 2021 at 7:10 PM Lad, Prabhakar
<prabhakar.csengg@xxxxxxxxx> wrote:
> On Sat, Dec 25, 2021 at 4:56 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Sat, Dec 25, 2021 at 4:08 AM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:

...

> > > +       ret = 0;
> >
> > I do not see the context, is it really necessary?
> >
> Yes the change is necessary as the probe callback returns ret on
> success, and in the below code flow there might be a case where ret
> inst set. So setting the ret here.

I can't believe this, so I have checked the code and it seems it uses
return ret at the end where it should be simply return 0. So, please,
fix it there.

-- 
With Best Regards,
Andy Shevchenko