Re: [PATCH 2/2] pinctrl: at91-pio4: Use platform_get_irq_optional() to get the interrupt

[Andy Shevchenko]

On Sat, Dec 25, 2021 at 3:59 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq_optional().


> +               ret = platform_get_irq_optional(pdev, i);
> +               if (ret < 0) {
>                         dev_err(dev, "missing irq resource for group %c\n",
>                                 'A' + i);
> -                       return -EINVAL;
> +                       return ret;
>                 }

This is an incorrect use of platform_get_irq_optional() (It's not
related to what Alexandre said, it's an additional comment).
NAK.

-- 
With Best Regards,
Andy Shevchenko