Re: [PATCH 2/8] net: pxa168_eth: Use platform_get_irq() to get the interrupt

[Andrew Lunn]

> >> +               goto err_netdev;
> >> +       BUG_ON(dev->irq < 0);
> >
> >
> > ??? What is this and how it supposed to work?
> >
> .. should have been BUG_ON(dev->irq < 0);

Is this fatal to the machine as a whole, now way to recover, all that
can be done is to limit the damage while it explodes?

If not, please use WARN_ON(), not BUG_ON(). There is an email from
Linus about this, not using BUG_ON() in general.

   Andrew