Re: [PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

From: Martin Blumenstingl
Date: Fri Dec 24 2021 - 12:46:26 EST


Hello,

first of all: thanks for working on this!

On Fri, Dec 24, 2021 at 8:17 AM Shunzhou.Jiang
<shunzhou.jiang@xxxxxxxxxxx> wrote:
>
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
Here the spelling of "domains" is correct but in the subject line it's
not (the subject has: doamins)

> The bindings targets the Amlogic s4, in which the power domain registers
> are in secure world.
>
> Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@xxxxxxxxxxx>
I found your name in an Android kernel maintainers file with a space
(instead of a dot): Shunzhou Jiang
In Germany a space between the names would be correct - but I can't
tell what's right or wrong for your case.

PS: as a small side-note: when using multiple patches we typically
send a cover-letter.
You can use the following patch-set/series as an example: [0]
It's not critical but it certainly helps identify which patches belong together.


Best regards,
Martin


[0] https://lore.kernel.org/linux-amlogic/20211214022100.14841-1-qianggui.song@xxxxxxxxxxx/T/