Re: [PATCH] tracing: fix mismatched comment in __string_len

From: Masami Hiramatsu
Date: Fri Dec 24 2021 - 08:48:34 EST


On Wed, 22 Dec 2021 19:00:25 +0800
Geliang Tang <geliang.tang@xxxxxxxx> wrote:

> Here __assign_str_len() should be used for the __string_len type, instead
> of __assign_str().
>

Yeah, the comment in the above line is correct :)

Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thanks!

> Signed-off-by: Geliang Tang <geliang.tang@xxxxxxxx>
> ---
> samples/trace_events/trace-events-sample.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
> index 5ab74fc9a2df..cbbbb83beced 100644
> --- a/samples/trace_events/trace-events-sample.h
> +++ b/samples/trace_events/trace-events-sample.h
> @@ -155,7 +155,7 @@
> *
> * To assign this string, use the helper macro __assign_str_len().
> *
> - * __assign_str(foo, bar, len);
> + * __assign_str_len(foo, bar, len);
> *
> * Then len + 1 is allocated to the ring buffer, and a nul terminating
> * byte is added. This is similar to:
> --
> 2.31.1
>


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>