Re: [PATCH 03/26] x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions

[Kirill A. Shutemov]

On Fri, Dec 24, 2021 at 10:16:16AM +0100, Paolo Bonzini wrote:
> On 12/23/21 17:55, Kirill A. Shutemov wrote:
> > 	In a TDX based VM, since the VMM is an untrusted entity, an intermediary
> > 	layer -- TDX module -- facilitates secure communication between the host
> > 	and the guest. TDX module is loaded like a firmware into a special CPU
> > 	mode called SEAM. TDX guests communicate with the TDX module using the
> > 	TDCALL instruction.
> > 
> > Does it look fine?
> 
> Looks good but I wouldn't say "like a firmware".  The TDX module is the
> "real" hypervisor, it's not firmware.

We are talking about the way it gets loaded, not about its functionality.
> 
> Paolo
> 

-- 
 Kirill A. Shutemov