Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

[Robin Murphy]

On 2021-12-17 18:42, Peter Geis wrote:
> On Fri, Dec 17, 2021 at 1:30 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
> > 17.12.2021 21:16, Peter Geis пишет:
> > > > > +                     break;
> > > > > +             default:
> > > > > +                     dev_info(&client->dev, "pmic controlled board reset not supported\n");
> >
> > I'd change this dev_info to dev_dbg to not clutter KMSG.
>
> I'd prefer to leave this as info, since the device is designated as
> the system power controller but it is only capable of powering down
> the system, not rebooting it.
> But on second thought, anyone who's making these changes would be
> investigating the driver anyway.
> So I'll change it to dev_dbg.

Indeed, this is the expected case for RK808, which has to be 
system-power-controller if you want shutdown to actually power off.

Cheers,
Robin.