Re: [PATCH] virtio: fix spelling error
From: asmadeus
Date: Wed Dec 15 2021 - 22:19:02 EST
Thanks for the patch.
A few comments below:
zhuxinran wrote on Thu, Dec 16, 2021 at 11:08:36AM +0800:
> Subject: virtio: fix spelling error
"virtio" is much more than this.
Have a look at previous commit messages for this file, something like
'9p/trans_virtio' would make a better component name.
(`git log net/9p/trans_virtio.c` to get git history for a single file)
> start my first kernel patch commit
This is not particularly useful for someone reading the git log, I'd
just remove this line.
I can do both changes on my end, but since you're learning it can also
be a good time to also see how to send a v2 (setting subject as [PATCH
v2], sending patch with in-reply-to)
I don't really mind either way, please let me know if you won't resend.
--
Dominique