Re: [PATCH] mlxsw: core: Switch to kvfree_rcu() API

[Uladzislau Rezki]

On Wed, Dec 15, 2021 at 12:18:43PM +0100, Uladzislau Rezki (Sony) wrote:
> Instead of invoking a synchronize_rcu() to free a pointer
> after a grace period we can directly make use of new API
> that does the same but in more efficient way.
> 
> TO: David S. Miller <davem@xxxxxxxxxxxxx>
> TO: Jakub Kicinski <kuba@xxxxxxxxxx>
> TO: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
> index 3fd3812b8f31..47c29769759b 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
> @@ -2190,8 +2190,7 @@ void mlxsw_core_rx_listener_unregister(struct mlxsw_core *mlxsw_core,
>  	if (!rxl_item)
>  		return;
>  	list_del_rcu(&rxl_item->list);
> -	synchronize_rcu();
> -	kfree(rxl_item);
> +	kvfree_rcu(rxl_item);
>  }
>  EXPORT_SYMBOL(mlxsw_core_rx_listener_unregister);
>  
> -- 
> 2.30.2
> 
+ David S. Miller <davem@xxxxxxxxxxxxx>
+ Jakub Kicinski <kuba@xxxxxxxxxx>
+ netdev@xxxxxxxxxxxxxxx

--
Vlad Rezki