Re: [PATCH 2/3] perf script: Fix CPU filtering of a script's switch events

From: Namhyung Kim
Date: Wed Dec 15 2021 - 13:05:55 EST


On Wed, Dec 15, 2021 at 12:07 AM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> CPU filtering was not being applied to a script's switch events.
>
> Fixes: 5bf83c29a0ad2 ("perf script: Add scripting operation process_switch()")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung

> ---
> tools/perf/builtin-script.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 9434367af166..c82b033e8942 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2473,7 +2473,7 @@ static int process_switch_event(struct perf_tool *tool,
> if (perf_event__process_switch(tool, event, sample, machine) < 0)
> return -1;
>
> - if (scripting_ops && scripting_ops->process_switch)
> + if (scripting_ops && scripting_ops->process_switch && !filter_cpu(sample))
> scripting_ops->process_switch(event, sample, machine);
>
> if (!script->show_switch_events)
> --
> 2.25.1
>