Re: [net-next PATCH RFC v6 07/16] net: dsa: tag_qca: enable promisc_on_master flag

From: Vladimir Oltean
Date: Wed Dec 15 2021 - 04:58:36 EST


On Tue, Dec 14, 2021 at 11:44:00PM +0100, Ansuel Smith wrote:
> Ethernet MDIO packets are non-standard and DSA master expects the first
> 6 octets to be the MAC DA. To address these kind of packet, enable
> promisc_on_master flag for the tagger.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> ---
> net/dsa/tag_qca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c
> index 34e565e00ece..f8df49d5956f 100644
> --- a/net/dsa/tag_qca.c
> +++ b/net/dsa/tag_qca.c
> @@ -68,6 +68,7 @@ static const struct dsa_device_ops qca_netdev_ops = {
> .xmit = qca_tag_xmit,
> .rcv = qca_tag_rcv,
> .needed_headroom = QCA_HDR_LEN,
> + .promisc_on_master = true,
> };
>
> MODULE_LICENSE("GPL");
> --
> 2.33.1
>

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>