Re: [PATCH v2 2/2] clk: qcom: Add clock driver for SM8450

[Stephen Boyd]

Quoting Vinod Koul (2021-12-13 21:34:51)
> On 09-12-21, 00:26, Stephen Boyd wrote:
> > Quoting Vinod Koul (2021-12-07 03:40:03)
> > > diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c
> > > new file mode 100644
> > > index 000000000000..82ac419718d7
> > > --- /dev/null
> > > +++ b/drivers/clk/qcom/gcc-sm8450.c
> > > @@ -0,0 +1,3303 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
> > > + * Copyright (c) 2021, Linaro Limited
> > > + */
> > > +
> > > +#include <linux/module.h>
> > > +#include <linux/of_device.h>
> > > +#include <linux/regmap.h>
> > 
> > BTW, clk providers need to include clk-provider.h
> 
> It is included but indirectly thru clk-alpha-pll.h.. I think this should
> be fine.

No