RE: [PATCH] phy: freescale: pcie: explictly add bitfield.h

[Hongxing Zhu]

> -----Original Message-----
> From: Vinod Koul <vkoul@xxxxxxxxxx>
> Sent: Wednesday, December 15, 2021 2:09 PM
> To: Kishon Vijay Abraham I <kishon@xxxxxx>; Hongxing Zhu
> <hongxing.zhu@xxxxxxx>
> Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; Vinod Koul <vkoul@xxxxxxxxxx>;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel test robot <lkp@xxxxxxxxx>
> Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> 
> kernel test robot complains about missing FIELD_PREP, so include
> bitfield.h for that
> 
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver")
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
Reviewed-by: Richard Zhu <hongxing.zhu@xxxxxxx>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and tests.

Best Regards
Richard Zhu

> ---
>  drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index f6502463d49a..04b1aafb29f4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -3,6 +3,7 @@
>   * Copyright 2021 NXP
>   */
> 
> +#include <linux/bitfield.h>
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/iopoll.h>
> --
> 2.31.1