Re: [PATCH 5.10 000/132] 5.10.85-rc1 review

From: Jakub Kicinski
Date: Tue Dec 14 2021 - 10:01:05 EST


On Tue, 14 Dec 2021 07:43:18 +0100 Krzysztof Kozlowski wrote:
> On 13/12/2021 19:17, Tadeusz Struk wrote:
> > On 12/13/21 01:29, Greg Kroah-Hartman wrote:
> >> This is the start of the stable review cycle for the 5.10.85 release.
> >> There are 132 patches in this series, all will be posted as a response
> >> to this one. If anyone has any issues with these being applied, please
> >> let me know.
> >>
> >> Responses should be made by Wed, 15 Dec 2021 09:29:16 +0000.
> >> Anything received after that time might be too late.
> >>
> >> The whole patch series can be found in one patch at:
> >> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.85-rc1.gz
> >> or in the git tree and branch at:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> >> and the diffstat can be found below.
> >
> > In this release cycle there were two similar nfc fixes:
> >
> > fd79a0cbf0b2 nfc: fix segfault in nfc_genl_dump_devices_done
> > 4cd8371a234d nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
> >
> > The list here only includes the second one. The first is still missing.
> > The same applies to 5.15
>
> With my review tag for this other fix I mentioned it needs Fixes and
> Cc-stable, but these were not added by Jakub when applying. It won't be
> picked up automatically by Greg.
>
> Jakub,
> What's weird, the cc-stable was also removed from my commit which is not
> good. Few other people add Fixes tag without Cc-stable when they want to
> annotate it should not go to stable. This one should go to stable, so it
> should have cc-stable (which I put there).

😳 no idea what happened here, I remember adding the tags, sorry..