Re: [PATCH] regulator: pca9450.h: Correct register masks for LDOs

[André Werner]

Quoting Mark Brown <broonie@xxxxxxxxxx>:

> On Mon, Dec 13, 2021 at 08:23:19AM +0100, André Werner wrote:
> > Within the defines of the register masks for LDO3 and LDO4,
> > the most significant bit was missing. The datasheet said
> > the range is 4:0 bits. Thus, the output voltage cannot be
> > set above 1.7V for each.
>
> This doesn't apply against current code, please check and resend.

From ade25a42e56c341073fc4b35e8096d01522b9046 Mon Sep 17 00:00:00 2001
From: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Dec 2021 08:41:14 +0100
Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

Within the defines of the register masks for LDO3 and LDO4,
the most significant bit was missing. The datasheet said
the range is 4:0 bits. Thus, the output voltage cannot be
set above 1.7V for each.

Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
---
 include/linux/regulator/pca9450.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/regulator/pca9450.h  
b/include/linux/regulator/pca9450.h
index 71902f41c919..0c3edff6bdff 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {

 /* PCA9450_REG_LDO3_VOLT bits */
 #define LDO3_EN_MASK                   0xC0
-#define LDO3OUT_MASK                   0x0F
+#define LDO3OUT_MASK                   0x1F

 /* PCA9450_REG_LDO4_VOLT bits */
 #define LDO4_EN_MASK                   0xC0
-#define LDO4OUT_MASK                   0x0F
+#define LDO4OUT_MASK                   0x1F

 /* PCA9450_REG_LDO5_VOLT bits */
 #define LDO5L_EN_MASK                  0xC0
--
2.31.1

Attachment: binWV0GFC7Jti.bin
Description: PGP Public Key