RE: [EXT] Re: [PATCH v6 4/4] perf/marvell: cn10k DDR perf event core ownership

From: Bharat Bhushan
Date: Tue Dec 14 2021 - 07:27:33 EST




> -----Original Message-----
> From: Will Deacon <will@xxxxxxxxxx>
> Sent: Tuesday, December 14, 2021 5:55 PM
> To: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> Cc: mark.rutland@xxxxxxx; robh+dt@xxxxxxxxxx; Bhaskara Budiredla
> <bbudiredla@xxxxxxxxxxx>; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v6 4/4] perf/marvell: cn10k DDR perf event core
> ownership
>
> External Email
>
> ----------------------------------------------------------------------
> On Fri, Oct 29, 2021 at 05:26:43PM +0530, Bharat Bhushan wrote:
> > As DDR perf event counters are not per core, so they should be
> > accessed only by one core at a time. Select new core when previously
> > owning core is going offline.
> >
> > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> > ---
> > v1->v6
> > - No Change
> >
> > drivers/perf/marvell_cn10k_ddr_pmu.c | 50 ++++++++++++++++++++++++++--
> > include/linux/cpuhotplug.h | 1 +
> > 2 files changed, 49 insertions(+), 2 deletions(-)
>
> I don't think the driver is much use without this patch, so please can you move
> the Kconfig stuff to a patch at the end so that the driver can't be enabled in a
> broken state half way through the series?

Okay, will change.

Thanks
-Bharat

>
> Will