RE: [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for various serdes protocols

[Leo Li]

> -----Original Message-----
> From: Shawn Guo <shawnguo@xxxxxxxxxx>
> Sent: Tuesday, December 14, 2021 3:22 PM
> To: Leo Li <leoyang.li@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> Alexandru Marginean <alexandru.marginean@xxxxxxx>; Ioana Ciornei
> <ioana.ciornei@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>; Jason
> Liu <jason.hui.liu@xxxxxxx>; Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Subject: Re: [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for various
> serdes protocols
> 
> On Fri, Dec 03, 2021 at 06:17:18PM -0600, Li Yang wrote:
> > From: Alex Marginean <alexandru.marginean@xxxxxxx>
> >

[snip]

> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-9999.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-9999.dts
> > new file mode 100644
> > index 000000000000..1ef743c48e84
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-9999.dts
> > @@ -0,0 +1,79 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Device Tree fragment for LS1028A QDS board, serdes 85xx
> > + *
> > + * Copyright 2019-2021 NXP
> > + *
> > + * Requires a LS1028A QDS board without lane B rework.
> > + * Requires a SCH-24801 card in slot 1.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +/ {
> > +	fragment@0 {
> 
> Is fragment0 more appropriate maybe, as @unit-address requires a
> corresponding 'reg' property?

Not sure if the overlay framework will use the index information somehow, but this is how it is demonstrated in the Documentation/devicetree/overlay-notes.rst document.

Regards,
Leo