Re: [PATCH v5 0/3] usb: meson: fix shared reset control use

From: Neil Armstrong
Date: Mon Dec 13 2021 - 08:30:58 EST


Hi Amljad,

On 12/12/2021 21:18, Amjad Ouled-Ameur wrote:
> This patchset fixes a usb suspend warning seen on the libretech-cc by
> using reset_control_rearm() call of the reset framework API.
> This call allows a reset consummer to release the reset line even when
> just triggered so that it may be triggered again by other reset
> consummers.
>
> reset_control_(de)assert() calls are called, in some meson usb drivers,
> on a shared reset line when reset_control_reset has been used. This is not
> allowed by the reset framework.
>
> Finally the meson usb drivers are updated to use this new call, which
> solves the suspend issue addressed by the previous reverted
> commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control
> use").
>
> changes since v4:
> - call reset_control_rearm() after clk_prepare_enable() fails
>
> Amjad Ouled-Ameur (3):
> phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use
> phy: amlogic: meson8b-usb2: Use dev_err_probe()
> phy: amlogic: meson8b-usb2: fix shared reset control use
>
> drivers/phy/amlogic/phy-meson-gxl-usb2.c | 5 ++++-
> drivers/phy/amlogic/phy-meson8b-usb2.c | 9 +++++++--
> 2 files changed, 11 insertions(+), 3 deletions(-)
>

For whole serie:

Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

Thanks for fixing that !

Neil