Re: [PATCH v20] tty: Fix the keyboard led light display problem

[Joe Perches]

On Mon, 2021-12-13 at 14:15 +0200, Andy Shevchenko wrote:
> On Mon, Dec 13, 2021 at 02:12:44PM +0800, lianzhi chang wrote:

> > +	struct kbd_struct *kb = &kbd_table[console];
> > +	int ret = 0;
> > +	unsigned long flags;
> 
> Slightly better to read:
> 
> 	struct kbd_struct *kb = &kbd_table[console];
> 	unsigned long flags;
> 	int ret = 0;

I don't think so.  Why do you?