Re: [PATCH v2 5/8] dt-bindings: misc: add property to support non-secure DSP

From: Stephan Gerhold
Date: Mon Dec 13 2021 - 05:57:36 EST


On Thu, Dec 09, 2021 at 12:06:23PM +0000, Srinivas Kandagatla wrote:
> From: Jeya R <jeyr@xxxxxxxxxxxxxx>
>
> Add property to set DSP domain as non-secure.
>
> ADSP/MDSP/SDSP are by default secured, where as CDSP can be either be
> secured/unsecured.

Wouldn't it be easier to avoid the negation and add a "qcom,secure-domain"
property instead? Given PATCH 8/8 ("arm64: dts: qcom: add non-secure
domain property to fastrpc nodes") it looks like you are intentionally
breaking DT compatibility here, but this patch does not justify why this
is necessary.

Thanks,
Stephan