RE: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get underflow error from DMA descriptor

From: Xiaoliang Yang
Date: Sun Dec 12 2021 - 19:49:23 EST



On Fri, 11 Dec 2021 00:07:13 Jakub Kicinski wrote:
> > > > 5 queues with FIFO cut-through mode can work well after applying this
> patch.
> > >
> > > This never worked, correct? It's not a regression fix?
> >
> > Yes, it's never worked when the underflow error is observed in the
> > case of NFS boot on i.mx8mp. I'm not sure if other SoC have same issue
> > in this case, but I think it's necessary to increase the threshold
> > value in case of underflow error.
>
> Oh, so NFS boot works for the most part on i.mx8mp but under certain
> conditions (or with certain configuration?) this error can be observed and the
> boot will fail?
Yes, when configure the DMA as threshold mode, this error can be observed.

>
> > Do you mean that I need to send the patch as a bug fix to net branch?
>
> Your call, if you would like for the patch to go to stable and LTS releases -- then
> it need to be resent for net with a Fixes tag.
>
> LMK if you prefer net or net-next.
Because this error requires a certain condition in DTS file, and I haven't update the DTS file. So I prefer to add the patch in net-next, thanks.