Re: [PATCH v5 2/5] dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl bindings

From: Rob Herring
Date: Fri Dec 10 2021 - 16:17:58 EST


On Wed, Dec 08, 2021 at 03:41:25PM +0530, Srinivasa Rao Mandadapu wrote:
>
> On 12/8/2021 2:54 PM, Srinivas Kandagatla wrote:
> Thanks froYour time Srini!!!
> >
> > On 07/12/2021 15:35, Srinivasa Rao Mandadapu wrote:
> > > Add device tree binding Documentation details for Qualcomm SC7280
> > > LPASS LPI pinctrl driver.
> > >
> > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > > Co-developed-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > > Signed-off-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > > ---
> >
> >
> > I remember in my previous review that I requested you to use git mv for
> > renaming this
> Yes. Created patch with "git mv" and commit. Not sure why diff is not as
> expected.

The 'git mv' is not what matters. You need the -M option for
git-format-patch/send-email. There's a config option you can enable that
by default.

Rob