Re: [PATCH] pwm: atmel: remove redundant initialization of variable timeout

[Colin King (gmail)]

On 10/12/2021 07:45, Uwe Kleine-König wrote:
> On Fri, Dec 10, 2021 at 12:22:50AM +0000, Colin Ian King wrote:
> > The variable timeout is being initialized with a value that is never
> > read, it is being re-assigned the same value later on. Remove the
> > redundant initialization and keep the latter assignment because it's
> > closer to the use of the variable.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> > ---
> >   drivers/pwm/pwm-atmel.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
> > index 98b34ea9f38e..8e00a4286145 100644
> > --- a/drivers/pwm/pwm-atmel.c
> > +++ b/drivers/pwm/pwm-atmel.c
> > @@ -271,7 +271,7 @@ static void atmel_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm,
> >   			      bool disable_clk)
> >   {
> >   	struct atmel_pwm_chip *atmel_pwm = to_atmel_pwm_chip(chip);
> > -	unsigned long timeout = jiffies + 2 * HZ;
> > +	unsigned long timeout;
> >   
> >   	atmel_pwm_wait_nonpending(atmel_pwm, pwm->hwpwm);
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> Did you spot this by using some static checker? If so, maybe attribute
> it in the commit log?

Just clang.

> Thanks
> Uwe