Re: [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq

[Andy Shevchenko]

On Fri, Dec 10, 2021 at 8:43 AM Akhil R <akhilrajeev@xxxxxxxxxx> wrote:
>
> > 09.12.2021 19:28, Akhil R пишет:
> > > -     err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
> > > -                                    &i2c_dev->bus_clk_rate);
> > > -     if (err)
> > > -             i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
> > > +     i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);
> >
> > Was this patch tested at all? Apparently, it wasn't compile-tested.
> Sorry, it got somehow missed as the build did not fail when prepared
> the image for testing. Thanks for pointing this out.
> Would fix and update.

It is because Dmitry runs `make W=1 ...`. Otherwise these types of
warnings are hidden.

> > drivers/i2c/busses/i2c-tegra.c: In function ‘tegra_i2c_parse_dt’:
> > drivers/i2c/busses/i2c-tegra.c:1635:13: warning: unused variable ‘err’ [-
> > Wunused-variable]
> >  1635 |         int err;
> >
> > BTW, MM, DRI and media mailing lists have nothing to do with this patch
> Even I was wondering on this, but apparently those lists are shown if get_maintainer.pl
> is run. Would remove the mailing lists going further.

I would recommend using my script [1] which has good heuristics.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

-- 
With Best Regards,
Andy Shevchenko