Re: [PATCH] hwmon: (nct6775) add support for TSI temperature registers

From: Zev Weiss
Date: Fri Dec 10 2021 - 03:16:52 EST


On Wed, Nov 10, 2021 at 03:14:39PM PST, Zev Weiss wrote:
These registers report CPU temperatures (and, depending on the system,
sometimes chipset temperatures) via the TSI interface on AMD systems.
They're distinct from most of the other Super-IO temperature readings
(CPUTIN, SYSTIN, etc.) in that they're not a selectable source for
monitoring and are in a different (higher resolution) format, but can
still provide useful temperature data.

Signed-off-by: Zev Weiss <zev@xxxxxxxxxxxxxxxxx>
Tested-by: Renze Nicolai <renze@xxxxxxxxx>
---

This patch has been tested on NCT6779 and NCT6798[1] hardware on
(respectively) ASRock Rack ROMED8HM3 and X570D4U boards, and seems to
work as expected; the implementation for the other chips supported by
the driver is purely based on the datasheets and has not been tested
(for lack of available hardware).

[1] Or at least, its chip ID registers identify it as an NCT6798 and
it seems to behave consistently with that, though it's actually
physically labeled as an NCT6796.

drivers/hwmon/nct6775.c | 136 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 130 insertions(+), 6 deletions(-)


Ping...any thoughts/feedback on this patch?


Thanks,
Zev