Re: [PATCH 6/7] workqueue: Remove the cacheline_aligned for nr_running

From: Lai Jiangshan
Date: Thu Dec 09 2021 - 18:31:36 EST




On 2021/12/10 06:07, Tejun Heo wrote:
On Tue, Dec 07, 2021 at 03:35:42PM +0800, Lai Jiangshan wrote:
From: Lai Jiangshan <laijs@xxxxxxxxxxxxxxxxx>

nr_running is never modified remotely after the schedule callback in
wakeup path is removed.

Rather nr_running is often accessed with other fields in the pool
together, so the cacheline_aligned for nr_running isn't needed.

Does it even need to be atomic anymore?


It doesn't need to be atomic, it is only modified in its associated CPU
in process context.