Re: [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq

[Dmitry Osipenko]

09.12.2021 19:28, Akhil R пишет:
> -	err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
> -				       &i2c_dev->bus_clk_rate);
> -	if (err)
> -		i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
> +	i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);

Was this patch tested at all? Apparently it wasn't compile-tested.

drivers/i2c/busses/i2c-tegra.c: In function ‘tegra_i2c_parse_dt’:
drivers/i2c/busses/i2c-tegra.c:1635:13: warning: unused variable ‘err’ [-Wunused-variable]
 1635 |         int err;

BTW, MM, DRI and media mailing lists have nothing to do with this patch