AW: [PATCH v2] arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini

[Mueller, Reinhold]

Hi Rob,

sorry for the late response.
The former guy has left the company. So i have taken the work for now.

I splitted the recent patch:
[PATCH v2] arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini
in dts patches and yaml patches and did the necessary checks.

I will resent the new patchset: new emtrion hardware emCON-MX8M Mini

Regards
Reinhold


Reinhold Mueller
Software engineer


emtrion GmbH
Am Hasenbiel 6 | 76297 Stutensee | Germany

Phone +49 7244 62694 20
Fax +49 7244 62694 19
Email Reinhold.Mueller@xxxxxxxxxx
Online www.emtrion.de




emtrion GmbH • Amtsgericht Mannheim • HRB 110 300 • Geschäftsführer: Ramona Maurer, Achmed Haddou • Umsatzsteueridentifikationsnummer:DE813694260 • Impressum: www.emtrion.de/de/impressum.html

HINWEIS: Personenbezogene Daten, die Sie per E-Mail an uns übermitteln, werden bei uns gespeichert und verarbeitet. Informationen zu unseren gesetzlichen Informationspflichten, zu uns und unseren Dienstleistungen finden Sie in unseren Datenschutzhinweisen.
Diese E-Mail kann vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind, oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte den Absender und vernichten diese Mail. Das unerlaubte kopieren, sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
> -----Ursprüngliche Nachricht-----
> Von: Rob Herring <robh@xxxxxxxxxx>
> Gesendet: Montag, 25. Oktober 2021 20:17
> An: Sreerama, Thanushree <Thanushree.Sreerama@xxxxxxxxxx>
> Cc: linux-imx@xxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> shawnguo@xxxxxxxxxx; robh+dt@xxxxxxxxxx; Erdrich, Frank
> <Frank.Erdrich@xxxxxxxxxx>; kernel@xxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; LinuxArmKernelMailingListe <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; s.hauer@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx
> Betreff: Re: [PATCH v2] arm64: dts: imx8mm: Add support for emtrion
> emCON-MX8M Mini
>
> On Mon, 25 Oct 2021 18:15:09 +0200, thanushree.sreerama@xxxxxxxxxxx
> wrote:
> > From: Thanushree Sreerama <thanushree.sreerama@xxxxxxxxxxx>
> >
> > This patch adds support for the emtrion GmbH emCON-MX8M Mini
> modules.
> > They are available with NXP i.MX 8M Mini equipped with 2 or 4 GB
> Memory.
> >
> > The devicetree imx8mm-emcon.dtsi is the common part providing all
> > module components and the basic support for the SoC. The support for the
> > avari baseboard in the developer-kit configuration is provided by the
> > emcon-avari dts files.
> >
> > Signed-off-by: Thanushree Sreerama
> <thanushree.sreerama@xxxxxxxxxxx>
> > Reviewed by: Frank Erdrich <frank.erdrich@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/arm/fsl.yaml          |   1 +
> >  arch/arm64/boot/dts/freescale/Makefile        |   3 +-
> >  .../boot/dts/freescale/imx8mm-emcon-avari.dts |  23 +
> >  .../dts/freescale/imx8mm-emcon-avari.dtsi     | 141 ++++
> >  .../boot/dts/freescale/imx8mm-emcon.dtsi      | 645
> ++++++++++++++++++
> >  5 files changed, 812 insertions(+), 1 deletion(-)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emcon-
> avari.dts
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emcon-
> avari.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/arm/fsl.yaml:714:1: [error] syntax
> error: found character '\t' that cannot start any token (syntax)
>
> dtschema/dtc warnings/errors:
> make[1]: *** Deleting file
> 'Documentation/devicetree/bindings/arm/fsl.example.dts'
> Traceback (most recent call last):
>   File "/usr/local/bin/dt-extract-example", line 45, in <module>
>     binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line
> 434, in load
>     return constructor.get_single_data()
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py",
> line 120, in get_single_data
>     node = self.composer.get_single_node()
>   File "_ruamel_yaml.pyx", line 706, in
> _ruamel_yaml.CParser.get_single_node
>   File "_ruamel_yaml.pyx", line 724, in
> _ruamel_yaml.CParser._compose_document
>   File "_ruamel_yaml.pyx", line 775, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 889, in
> _ruamel_yaml.CParser._compose_mapping_node
>   File "_ruamel_yaml.pyx", line 775, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 889, in
> _ruamel_yaml.CParser._compose_mapping_node
>   File "_ruamel_yaml.pyx", line 775, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 889, in
> _ruamel_yaml.CParser._compose_mapping_node
>   File "_ruamel_yaml.pyx", line 773, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 850, in
> _ruamel_yaml.CParser._compose_sequence_node
>   File "_ruamel_yaml.pyx", line 775, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 889, in
> _ruamel_yaml.CParser._compose_mapping_node
>   File "_ruamel_yaml.pyx", line 773, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 850, in
> _ruamel_yaml.CParser._compose_sequence_node
>   File "_ruamel_yaml.pyx", line 775, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 889, in
> _ruamel_yaml.CParser._compose_mapping_node
>   File "_ruamel_yaml.pyx", line 773, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 852, in
> _ruamel_yaml.CParser._compose_sequence_node
>   File "_ruamel_yaml.pyx", line 904, in
> _ruamel_yaml.CParser._parse_next_event
> ruamel.yaml.scanner.ScannerError: while scanning for the next token
> found character that cannot start any token
>   in "<unicode string>", line 714, column 1
> make[1]: *** [Documentation/devicetree/bindings/Makefile:20:
> Documentation/devicetree/bindings/arm/fsl.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/arm/fsl.yaml:  while scanning for the
> next token
> found character that cannot start any token
>   in "<unicode string>", line 714, column 1
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/arm/fsl.yaml: ignoring, error
> parsing file
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/arm/fsl.yaml
> make: *** [Makefile:1441: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1545835
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.