Re: [PATCH v2 1/3] of: Move simple-framebuffer device handling from simplefb to of

[Thomas Zimmermann]

Hi

Am 08.12.21 um 18:49 schrieb Rob Herring:
> On Tue, Dec 7, 2021 at 1:31 AM Hector Martin <marcan@xxxxxxxxx> wrote:
> > This code is required for both simplefb and simpledrm, so let's move it
> > into the OF core instead of having it as an ad-hoc initcall in the
> > drivers.
> >
> > Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
> > ---
> >   drivers/of/platform.c          |  5 +++++
> >   drivers/video/fbdev/simplefb.c | 21 +--------------------
> >   2 files changed, 6 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> > index b3faf89744aa..e097f40b03c0 100644
> > --- a/drivers/of/platform.c
> > +++ b/drivers/of/platform.c
> > @@ -540,6 +540,11 @@ static int __init of_platform_default_populate_init(void)
> >                  of_node_put(node);
> >          }
> >
> > +       for_each_child_of_node(of_chosen, node) {
> > +               if (of_device_is_compatible(node, "simple-framebuffer"))
>
> node = of_get_compatible_child(of_chosen, "simple-framebuffer");
> of_platform_device_create(node, NULL, NULL);
> of_node_put(node);
>
> Please Cc the DT list. Looks like this patch can be applied
> independently. (Better get the other 2 into drm-misc soon or it will
> miss 5.17).

Can we merge the whole patchset through drm-misc? Patches 2 and 3 are 
useless without the first one.

Best regards
Thomas

> Rob

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature